Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pnpm and mpl-token-metadata packages #108

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Update pnpm and mpl-token-metadata packages #108

merged 2 commits into from
Sep 5, 2024

Conversation

danenbm
Copy link
Contributor

@danenbm danenbm commented Sep 5, 2024 •
edited
Loading

  • Goal was to update pnpm version (whch caused no dependency changes) and @metaplex-foundation/mpl-token-metadata.
  • When regenerating the lockfile there were a bunch of unmet peer dependencies, so fixed those as well.
  • After updating unmet peer dependencies, had a few deprecated subdependencies warnings (see message below)
  • When I look up each of the deprecated subdependencies, they are for devDependencies, except for package.json seems like it's fine.
$ pnpm install
 WARN  7 deprecated subdependencies found: @humanwhocodes/[email protected], @humanwhocodes/[email protected], @npmcli/[email protected], [email protected], [email protected], [email protected], [email protected]
Packages: +10 -11
++++++++++-----------
Progress: resolved 1211, reused 1128, downloaded 0, added 10, done

devDependencies:
- @typescript-eslint/eslint-plugin 5.0.0
+ @typescript-eslint/eslint-plugin 5.62.0 (8.4.0 is available)

Done in 2.2s

@vercel Vercel
Copy link

vercel bot commented Sep 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mpl-bubblegum-js-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 8:41pm

@danenbm danenbm force-pushed the danenbm/update-pnpm-and-pkg branch from aca412e to 6c2a16f Compare September 5, 2024 20:40
@danenbm danenbm marked this pull request as ready for review September 5, 2024 20:48
@danenbm danenbm merged commit b061129 into main Sep 5, 2024
11 checks passed
@danenbm danenbm deleted the danenbm/update-pnpm-and-pkg branch September 5, 2024 21:42
This was referenced Sep 15, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blockiosaurus blockiosaurus blockiosaurus approved these changes

@nhanphan nhanphan Awaiting requested review from nhanphan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danenbm @blockiosaurus